-
Notifications
You must be signed in to change notification settings - Fork 0
[Feat]: ERD 기반 DB 모델 정리 및 Alembic initial migration 적용 #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
…postgresql-with-orm 5 feat sync postgresql with orm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docker-compose.yml 이 서버 컴 상에서 up 명령어로 실행되도록 deploy.yml ci/cd 설정 해놨는데 지우면 안됨.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
로컬에서 돌리려다 잘못 만져서 빼고 푸시함...
전 버전에서 가져와서 다시 넣겠습니다
.gitignore
Outdated
| postgres_data/ | ||
| postgres_data/ | ||
|
|
||
| .env |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.env 파일은 이미 fastapi-backend 디렉토리에서 ignore 되어있는데 왜 중복으로 하는지?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
젠장 거기에 있는지 모르고 또 추가했습니다
.gitignore
Outdated
|
|
||
| .env | ||
|
|
||
| .python-version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.python-version 은 파이썬 버전 관리툴로 도입한 uv를 위해 필요함.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK !
fastapi-backend/app/db/models.py
Outdated
| Torrey = "Torrey" | ||
| JangGiRyeo = "JangGiRyeo" | ||
| Kuyper = "Kuyper" | ||
| SonYangwon = "SonYangwon" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JangGiRyeo 는 한글 음절마다 Uppercase인데 SonYangwon은 lowercase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 이럴수가
|
추가적으로 각 모델 작성시마다 커밋 필요 (거의 line-by-line 수준 커밋) |
- Align models.py with ERD - Add initial Alembic migration as DB baseline - Remove empty legacy migration - Ignore docker-compose.yml for local environment
9f1781d to
5126e7d
Compare
|
gitignore 관련 수정사항 먼저 반영하여 커밋 추가했습니다. |
|
모델 수정 완료했습니다.
|
Jangmyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.python-version 이 프로젝트 root 말고 fastapi-backend 에 있어야됨
개요
ERD를 기준으로 DB 모델을 정리하고,
Alembic을 사용해 initial migration을 생성하여
이후 모든 기능 개발의 DB 스키마 기준점을 확정
본 PR은 후속 개발에 앞서 DB 구조를 확정하기 위한 작업입니다.
관련 이슈
작업 내용
models.py정리.env와 로컬 환경용 설정docker-compose.yml추가테스트 결과
upgrade head정상 동작 확인기타